[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Enforce USB interface claims
On Sun, Jan 23, 2005 at 03:12:58AM -0800, Chris Wedgwood wrote:
> Greg,
Adding linux-usb-devel to the CC:
> How would you feel about something like this?
>
> Index: cw-current/drivers/usb/core/devio.c
> ===================================================================
> --- cw-current.orig/drivers/usb/core/devio.c 2005-01-19 14:52:27.987890276 -0800
> +++ cw-current/drivers/usb/core/devio.c 2005-01-22 18:09:22.753895659 -0800
> @@ -417,10 +417,7 @@
> return -EINVAL;
> if (test_bit(ifnum, &ps->ifclaimed))
> return 0;
> - /* if not yet claimed, claim it for the driver */
> - dev_warn(&ps->dev->dev, "usbfs: process %d (%s) did not claim interface %u before use\n",
> - current->pid, current->comm, ifnum);
> - return claimintf(ps, ifnum);
> + return -EINVAL;
> }
>
> static int findintfep(struct usb_device *dev, unsigned int ep)
Um, why? I think this is there to help with "broken" userspace code
that was written before we enforced the rules of "you must claim an
interface before using it." As such, I don't think we can apply this
patch.
thanks,
greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Follow-Ups:
References: