[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] BUG in io_destroy (fs/aio.c:1248)
"Darrick J. Wong" <djwong@xxxxxxxxxx> wrote:
> Andrew Morton wrote:
> > So... Will someone be sending a new patch?
> Here's a cheesy patch that simply marks the ioctx as dead before
> destroying it.
super-cheesy, given that `ctx' is an unsigned long.
> + spin_lock_irq(&ctx->ctx_lock);
> + ctx->dead = 1;
> + spin_unlock_irq(&ctx->ctx_lock);
Even with this fixed up, the locking looks very odd.
Needs more work, please. Or we just run with the original patch which I
assume was tested. It's a rare error path and performance won't matter.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/