[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 01/04] Adding cipher mode context information to crypto_tfm
- From: James Morris <jmorris@xxxxxxxxxx>
- Date: Tue, 25 Jan 2005 10:52:54 -0500 (EST)
On Mon, 24 Jan 2005, Andrew Morton wrote:
> These patches clash badly with Michael Ludvig's work:
> so someone's going to have to rework things. Ordinarily Michael would go
> first due to test coverage.
> James, your call please. Also, please advise on the suitability of
> Michael's patches for a 2.6.11 merge.
I think the generic scatterwalk changes are more important and
fundamental (still to be fully reviewed).
I agree with Fruhwirth that the cipher code is starting to become
ungainly. I'm not sure these patches are heading in the right direction
from a design point of view, although we do need the functionality.
Perhaps temporarily drop the multible block changes above until we get the
generic scatterwalk code in and a cleaned up design to handle cipher mode
Fruhwirth, do you have any cycles to work on implementing your ideas for
more cleanly reworking Michal's multiblock code?
Also, I would think this is more 2.6.12 material, at this stage.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/