[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
use of uninitialized pointer in jffs_create()
- From: Jesper Juhl <jesper.juhl@xxxxxxxxx>
- Date: Sun, 21 Aug 2005 00:28:08 +0200
- Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:cc:mime-version:content-type:content-transfer-encoding:content-disposition; b=NbK7RTCSsG+vCrgqicpuReJqrzTDQrhPYRylbWf3UVnaSX/uQiBM0zfxlbBSY/MsCywhzX4xKMGSESYlTK1reRD/zV2R9MhP6I351CYW8cGLQeWCi7hZ5Fw4lYNhUje1pZgEvGfZcVqChyLkHcgV5od+ME0ZjcomstuY88e8wow=
gcc kindly pointed me at jffs_create() with this warning :
fs/jffs/inode-v23.c:1279: warning: `inode' might be used uninitialized
in this function
And looking at the function :
static int
jffs_create(struct inode *dir, struct dentry *dentry, int mode,
struct nameidata *nd)
{
struct jffs_raw_inode raw_inode;
struct jffs_control *c;
struct jffs_node *node;
struct jffs_file *dir_f; /* JFFS representation of the directory. */
struct inode *inode;
int err;
truncate_inode_pages(&inode->i_data, 0);
...
I think it is correct. How on earth is that call to
truncate_inode_pages() going to avoid blowing up? inode has not yet
been initialized... Looks like a bug to me.
Unfortunately I don't know anything about this code, so I haven't
attempted to fix it.
--
Jesper Juhl <jesper.juhl@xxxxxxxxx>
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Follow-Ups: